Tolerant parsing: continue parsing when a Glimmer syntax is invalid #1666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is far from ready, it simply aims at starting a discussion.
Context
When using
ember-template-lint
, any syntax error found throws aGlimmerSyntaxError
and makes the result of the lint process invalid. On a project I've been working on with @mansona, we would have needed some sort of "tolerant mode", a way to be notified about errors without blocking the linter.The current state of this PR is just a start, and aims at gathering feedbacks about the direction it should take:
PartialStatement
as an example and doesn't throw when a Handlebars partial is found, and the resulting AST template simply doesn't contain the node.Parser
seemed cleaner and less intrusive to me than trying to implement it as parse function's argument.